You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
which relies on the fact that File.writeln is part of the URL. To provide identical functionality for DDox, it would have to expand to:
a href="/library/std/stdio/File/writeln>writeln</a>
REF handles this by expanding to std.stdio.File.writeln and letting DDox recognize it as a symbol path, but I'm not aware of an equivalent feature in DDox that works like REF_ALTTEXT.
This patch makes it expand to:
writeln (std.stdio.File.writeln)
It's not ideal but it's an improvement over the broken output it currently generates.
@CyberShadow, it's used in a couple of PRs, including dlang/phobos#3911. It's intended as a companion to REF replacing all the _NAMED macros... but it's not a straight upgrade considering the less-than-ideal DDox implementation. Right now those macros simply link from DDox to DDoc.
@aG0aep6G, the root directory isn't the problem - we have ROOT_DIR for dlang.org. There's no way to "replace" dots with slashes using DDoc macros.
Yeah, it sucks. DDoc macros can only have one variadic component and we have no way of "splitting" one argument into many.
Markdown has [text here](link here). There's been some murmuring about Markdown before and maybe it would provide a better way out. For now the implementation in this PR is all I got.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For DDoc,
expands to
which relies on the fact that
File.writelnis part of the URL. To provide identical functionality for DDox, it would have to expand to:REFhandles this by expanding tostd.stdio.File.writelnand letting DDox recognize it as a symbol path, but I'm not aware of an equivalent feature in DDox that works likeREF_ALTTEXT.This patch makes it expand to:
It's not ideal but it's an improvement over the broken output it currently generates.