Skip to content

Conversation

@JakobOvrum
Copy link
Contributor

Depends on dlang/dlang.org/pull/1184.

Just an example to show how to use it for now.

@andralex
Copy link
Member

rebase

@JakobOvrum
Copy link
Contributor Author

Don't merge this until the dependency is merged.

@CyberShadow
Copy link
Member

@JakobOvrum Time to rebase?

@JakobOvrum
Copy link
Contributor Author

Rebased. The only real diff stems from the use of ROOT_DIR, which I'd say is a good sign that it works as a drop-in replacement.

The choice of std.array for this PR was fairly abitrary. I recently filed #3926 which applies MREF across all of Phobos. I'd like to convert this PR into one that similarly applies REF across all of Phobos (if we go ahead with that, it would help if #3926 was merged first, as it gets rid of many uses of LINK2). Thoughts?

Note that any macros in dlang.org.ddoc cannot be removed until they are verified to be unused across all three repositories.

@CyberShadow
Copy link
Member

LGTM

@CyberShadow
Copy link
Member

Auto-merge toggled on

@CyberShadow
Copy link
Member

Thanks, hurray for relative links.

@JakobOvrum
Copy link
Contributor Author

OK, I'll file future changes in a new PR then.

@CyberShadow
Copy link
Member

Auto-merge toggled off

@CyberShadow
Copy link
Member

Sorry, I somehow skipped over this paragraph:

The choice of std.array for this PR was fairly abitrary. I recently filed #3926 which applies MREF across all of Phobos. I'd like to convert this PR into one that similarly applies REF across all of Phobos (if we go ahead with that, it would help if #3926 was merged first, as it gets rid of many uses of LINK2). Thoughts?

@wilzbach
Copy link
Contributor

wilzbach commented Mar 7, 2016

OK, I'll file future changes in a new PR then.

AFAICT this was just a proposal, so it can be closed?

@JakobOvrum otherwise please rebase :)

@quickfur
Copy link
Member

Now that dlang/dlang.org#1257 has merged, is this ready to go?

Also, merge conflict; please rebase.

@JakobOvrum
Copy link
Contributor Author

If you'd like to help with this effort, please look at #3926.

@wilzbach
Copy link
Contributor

wilzbach commented Dec 9, 2016

Thanks to @aG0aep6G's efforts XREF got replaced with REF :)

Hence this is show case PR is not needed anymore.

@wilzbach wilzbach closed this Dec 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants