Skip to content

Conversation

@JakobOvrum
Copy link
Contributor

MREF was introduced in dlang/dlang.org/pull/1177. MREF fixes module links for DDox and other doc engines (and looks nicer on the page).

@JakobOvrum
Copy link
Contributor Author

The diff for the DDoc HTML output in the auto-tester stems from MREF not using $(D …) for the link text. Let's fix that first so that this PR has a null diff for the DDoc HTML output.

Some remaining LINK2 uses should be replaced by an MREF_ALTTEXT macro. I'll add that and fix those later.

@JakobOvrum
Copy link
Contributor Author

Actually, it seems that most existing links did not use $(D …), so let's leave MREF as-is.

@CyberShadow
Copy link
Member

Uh-oh. This replaces relative links with absolute links from the site root. Not sure this is an improvement. Oh, that's just DDox, never mind.

@CyberShadow
Copy link
Member

New problem: Now MREF links in /phobos-prerelease/ go back to /phobos/.

@JakobOvrum
Copy link
Contributor Author

New problem: Now MREF links in /phobos-prerelease/ go back to /phobos/.

Filed dlang/dlang.org/pull/1193

@JakobOvrum JakobOvrum force-pushed the ddoc_apply_mref branch 2 times, most recently from acc4028 to e886688 Compare January 13, 2016 05:16
@CyberShadow
Copy link
Member

I don't understand why this change is introducing an absolute link to dlang.org in phobos-prerelease/std_bigint.html. Oh, because you changed it to XREF. At this point I don't think this is an improvement.

@JakobOvrum
Copy link
Contributor Author

@CyberShadow, it's XREF. We're en route to replace XREF with REF, this'll get fixed then.

At this point I don't think this is an improvement.

XREF* -> REF will probably be a programmatic change. This helps with that (and XREF is better than LINK2 for DDox).

@CyberShadow
Copy link
Member

We're en route to replace XREF with REF, this'll get fixed then.

You mean redefine XREF to use REF, or replace usages of XREF with REF? Either way, why not replace it with REF here directly? The fewer macros we have, the better.

@JakobOvrum
Copy link
Contributor Author

Oh yeah, forgot that was merged. It wasn't when I filed this PR :)

@andralex
Copy link
Member

@CyberShadow leaving this to you - thx both!

@CyberShadow
Copy link
Member

Hmm, there's still some regressions e.g. in std.bigint.

Maybe we should define REF for DDox to be wrapped in $(D ...).

@quickfur
Copy link
Member

Rebase please.

@wilzbach
Copy link
Contributor

As far as i understand this just replaces LINK2 with MREF?
And sometimes it uses the code instead of a - is this bug already filled?

-        <a href="std_format.html#format">std.format.format</a>:
+        <code class="prettyprint lang-d">std.format.format</code>:

@wilzbach wilzbach mentioned this pull request Mar 30, 2016
@JackStouffer
Copy link
Contributor

ping @JakobOvrum

@CyberShadow
Copy link
Member

This came up on the forum today:
http://forum.dlang.org/post/bdzxfhjldgzullfjftws@forum.dlang.org

@wilzbach
Copy link
Contributor

I tried to push this with a resubmission - #4303

@JackStouffer
Copy link
Contributor

This was superseded. Can someone please close this?

@CyberShadow CyberShadow closed this Jun 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants