Skip to content

[stable] Fix up 2.087 C++ header regressions#10070

Merged
thewilsonator merged 4 commits intodlang:stablefrom
kinke:fixcpp
Jun 28, 2019
Merged

[stable] Fix up 2.087 C++ header regressions#10070
thewilsonator merged 4 commits intodlang:stablefrom
kinke:fixcpp

Conversation

@kinke
Copy link
Contributor

@kinke kinke commented Jun 21, 2019

At least those I've encountered so far, incl. a cherry-pick of #10065.

@kinke kinke requested a review from ibuclaw as a code owner June 21, 2019 17:37
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @kinke! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "stable + dmd#10070"

Copy link
Member

@ibuclaw ibuclaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests, and make it harder for people to blindly break this in future.

kinke added 2 commits June 26, 2019 20:59
It's a 64-bit value, so don't ignore the 32 upper bits, and print it as
signed value for easily readable small negative offsets.
@thewilsonator
Copy link
Contributor

Mecca failure unrelated.

@thewilsonator thewilsonator merged commit f44da91 into dlang:stable Jun 28, 2019
@kinke kinke deleted the fixcpp branch June 28, 2019 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

Comments