Update C++ headers - Follow up to #9282 by SSoulaimane · Pull Request #10065 · dlang/dmd

SSoulaimane · 2019-06-20T03:59:42Z

I forgot to update the C++ headers.

dlang-bot · 2019-06-20T03:59:43Z

Thanks for your pull request and interest in making D better, @SSoulaimane! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
I have provided a detailed rationale explaining my changes
New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.

If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + dmd#10065"

src/dmd/declaration.h

thewilsonator

Otherwise looks good

ibuclaw · 2019-06-20T06:13:47Z

Where's the tests?

SSoulaimane · 2019-06-20T06:14:57Z

How?

ibuclaw · 2019-06-20T06:15:30Z

https://github.com/dlang/dmd/blob/master/src/tests/cxxfrontend.c

ibuclaw · 2019-06-20T06:21:04Z

To better catch run-time corruption, I think:

Compile a nested function, and assert(fd->isNested())
Compile a non-nested function and assert(!fd->isNested())
Compile a struct with an allocator, but no deallocator, and assert(sd->aggNew && !sd->aggDelete)

SSoulaimane · 2019-06-20T06:28:02Z

Ok, but how is checking isNested() related to the ABI?

SSoulaimane · 2019-06-21T19:03:43Z

Since allocators were deprecated, I decided to check the next field (ctor) #10071.

C++ headers Integrity check - follows #10065 merged-on-behalf-of: Iain Buclaw <ibuclaw@gdcproject.org>

Felix Angell (1): update chocolatey install instructions Ivan Butygin (4): Jit: report parseBitcodeFile errors (#3055) Jit: BindPtr useful functions (#3057) Jit bind fixes (#3099) jit bind: fix static array handling (#3100) Martin Kinkelin (97): Azure CI: Upgrade Windows image to VS 2019 (#3052) Azure CI: Tweak ownership & permissions of tarballs (#3056) Replace LDC-specific VarDeclaration.scopeClassType by .onstackWithDtor Get rid of superfluous LDC-specific TypeBasic.alignment() override Streamline LDC front-end diff Clean up front-end diff some more Get rid of obsolete IN_LLVM_MSVC Upgrade front-end & libs to v2.086.0-beta.1 Fix up C++ headers Adapt to switch error lowering to object.__switch_error!() druntime: Don't require D_AVX for 256-bit core.simd vector aliases dmd-testsuite: Disable fail_compilation/vector_types.d Fix visibility issue in tests/codegen/gh1955.d Fix array casts with constant source lengths dmd-testsuite: Relax new runnable/testpdb.d tests Fix DIP1008 dmd-testsuite: Use -disable-linker-strip-dead for runnable/testpdb.d Fix merge regression wrt. captured vthis Fix repainting of compile-time reals for targets with 64-bit reals Merge v2.086.0-rc.2 Fix pragma(LDC_no_typeinfo) - elide TypeInfo emission for structs Extend pragma(LDC_no_typeinfo) to classes and interfaces Merge v2.086.0 Upgrade dub to v1.15.0 Enforce re-semantic for ThisExp.syntaxCopy() Revise naked asm headers (#3067) Try to restore compilability with ltsmaster Upgrade bundled mingw-w64-libs (with DLL entry point fix) (#3071) WebAssembly: Use --export-dynamic when linking with LLD 8+ (#3072) Phobos: Enable x87 asm versions for std.math.{tan,expi} (#2855) druntime: Add support for LLVM 7.1.* in ldc.intrinsics Merge upstream stable (4a2bab2469) Win64: Extend C++ ABI special case to include new copy ctors dmd-testsuite: Re-enable fail_compilation/fail9414{a,b}.d Fixup lit-test codegen/assign_struct_init_without_stack.d Merge upstream stable (b95818c122) Disallow some vector ops and fix integral vector identity comparisons druntime: Fix runnable/eh.d regression in rt.dwarfeh Fix `this` in functions nested in in/out contracts Merge upstream stable (0b606cad20) Refactoring: Replace isMusl() by triple.isMusl() Fix C assert calls for uClibc Improve error msg on global var collision (#3081) Merge v2.086.1-beta.1 Restore compilability with ltsmaster Merge v2.086.1 Changelog: Add v1.16.0 Upgrade front-end & libs to v2.087.0-beta.1 Fix up C++ headers Cherry-pick dlang/dmd#10065 Azure CI, Windows: Make step fail if ninja fails Adapt lit-tests to new floating-point init values druntime: Work around issue #2782 in object.d Adapt to new OS env variable value on Windows druntime: Fix standalone tests on Windows dmd-testsuite: Rework some new 2.087 tests Merge upstream stable (9ddedc4f9f) Restore compilability with ltsmaster Fix ICE when returning a void expression (#3095) Refactoring: Free TargetABI from legacy magic C++ structs (#3073) Merge upstream stable (6f5d87a93f) [OSX] druntime: Adapt to removed rt/osx_tls.c / add macOS 10.15 support Upgrade bundled dub to v1.16.0 CMake: Drop detection of unsupported ldc2 and gdc host compilers Emit fatal codegen error for unsupported dual-context for now dmd-testsuite: Disable new dual-context tests for now Merge upstream stable (307684dd70) dmd-testsuite: Skip some new tests in compilable/cppmangle.d Fix some ICEs in debuginfo generator wrt. opaque structs druntime: Initialize new msvcUsesUCRT in rt/msvc.c druntime: Support DSOs without TLS range in rt.sections_osx_x86_64 dmd-testsuite: Adapt LDC-and-Win32-specific REQUIRED_ARGS Merge upstream stable (791f90d559) Azure & Shippable CI: Upgrade LLVM to v8.0.1 Azure CI: Upgrade clang on Windows to v8.0.1 CircleCI: Disable parallel GC marking for 64-bit unittest runners on Linux CircleCI: Try to work around out-of-memory errors while building druntime: Merge upstream stable (post-2.087.1 -betterC fix) druntime: Add saturation arithmetic intrinsics (LLVM 8+) druntime: Add intrinsics llvm_minimum and llvm_maximum (LLVM 8+) Merge upstream stable (75db01db16) dmd-testsuite: Adapt expected output for new fail_compilation test Expand response files before parsing `-lowmem` Windows: Switch to wmain entry point & convert to UTF-8 (ldc2 & ldmd Windows: Make dmd.root.filename actually work with UTF-8 strings Fix manual cmdline parsing (ignore after -run) Don't emit DMD-style tracing with pragma(LDC_profile_instr, false) Windows: Switch console code page to UTF-8, for LDC and LDMD Use wide WinAPI functions Windows: Read environment variables as UTF-8 Use dmd.root.file for reading ldc2.conf Tweak usage of LLVM Unicode conversion functions Add lit-test wrt. application of --DRT-* options in response files Speculatively fix linkability of LDC and LDMD on Android (#3128) Azure CI Windows: Upgrade bundled libcurl to v7.65.3 (#3135) -fvisibility=hidden: Hide init symbols, TypeInfos and vtables too if the associated aggregate isn't exported (#3129) Changelog: Add v1.17.0 Moritz Maxeiner (1): Support building with gdmd host compiler Nicholas Wilson (2): Add ON/OFF to lit.site.cfg.in s.t. cmake flags can be set directly (#3088) add __traits(getTargetInfo, "dcomputeTargets") (#3090) myfreeweb (2): Do not require gold plugin when linking with LLD (#3105) Enable gc-sections on FreeBSD (#3106) skoppe (1): return 0 in getCriticalSectionSize for wasm (#3119)

SSoulaimane requested a review from ibuclaw as a code owner June 20, 2019 03:59

thewilsonator reviewed Jun 20, 2019

View reviewed changes

src/dmd/declaration.h Show resolved Hide resolved

SSoulaimane mentioned this pull request Jun 20, 2019

Deprecate "Fix for the non-global template issue 5710" #9702

Merged

thewilsonator approved these changes Jun 20, 2019

View reviewed changes

SSoulaimane force-pushed the update_headers branch from b3d999e to 03a49cc Compare June 20, 2019 04:02

Update C++ headers - Follow up to dlang#9282

03a49cc

thewilsonator added the Merge:auto-merge label Jun 20, 2019

dlang-bot merged commit 6361ef6 into dlang:master Jun 20, 2019

kinke added a commit to kinke/ldc that referenced this pull request Jun 21, 2019

Cherry-pick dlang/dmd#10065

b02cdf6

kinke added a commit to kinke/ldc that referenced this pull request Jun 21, 2019

Cherry-pick dlang/dmd#10065

63f1c46

kinke mentioned this pull request Jun 21, 2019

[stable] Fix up 2.087 C++ header regressions #10070

Merged

SSoulaimane added a commit to SSoulaimane/dmd that referenced this pull request Jun 21, 2019

C++ headers Integrity check - follows dlang#10065

dfe6c49

SSoulaimane added a commit to SSoulaimane/dmd that referenced this pull request Jun 22, 2019

C++ headers Integrity check - follows dlang#10065

0482f78

SSoulaimane added a commit to SSoulaimane/dmd that referenced this pull request Jun 22, 2019

C++ headers Integrity check - follows dlang#10065

5d67cfb

dlang-bot added a commit that referenced this pull request Jun 26, 2019

Merge pull request #10071 from SSoulaimane/cxxtest

bc6bb99

C++ headers Integrity check - follows #10065 merged-on-behalf-of: Iain Buclaw <ibuclaw@gdcproject.org>

kinke added a commit to kinke/ldc that referenced this pull request Jun 26, 2019

Cherry-pick dlang/dmd#10065

0a8ba41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update C++ headers - Follow up to #9282#10065

Update C++ headers - Follow up to #9282#10065
dlang-bot merged 1 commit intodlang:masterfrom
SSoulaimane:update_headers

SSoulaimane commented Jun 20, 2019

Uh oh!

dlang-bot commented Jun 20, 2019

Uh oh!

Uh oh!

thewilsonator left a comment

Uh oh!

ibuclaw commented Jun 20, 2019

Uh oh!

SSoulaimane commented Jun 20, 2019

Uh oh!

ibuclaw commented Jun 20, 2019

Uh oh!

ibuclaw commented Jun 20, 2019 •

edited

Loading

Uh oh!

SSoulaimane commented Jun 20, 2019 •

edited

Loading

Uh oh!

SSoulaimane commented Jun 21, 2019 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

SSoulaimane commented Jun 20, 2019

Uh oh!

dlang-bot commented Jun 20, 2019

Bugzilla references

Testing this PR locally

Uh oh!

Uh oh!

thewilsonator left a comment

Choose a reason for hiding this comment

Uh oh!

ibuclaw commented Jun 20, 2019

Uh oh!

SSoulaimane commented Jun 20, 2019

Uh oh!

ibuclaw commented Jun 20, 2019

Uh oh!

ibuclaw commented Jun 20, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SSoulaimane commented Jun 20, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SSoulaimane commented Jun 21, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ibuclaw commented Jun 20, 2019 •

edited

Loading

SSoulaimane commented Jun 20, 2019 •

edited

Loading

SSoulaimane commented Jun 21, 2019 •

edited

Loading