Skip to content

C++ headers Integrity check - follows #10065#10071

Merged
dlang-bot merged 2 commits intodlang:masterfrom
SSoulaimane:cxxtest
Jun 26, 2019
Merged

C++ headers Integrity check - follows #10065#10071
dlang-bot merged 2 commits intodlang:masterfrom
SSoulaimane:cxxtest

Conversation

@SSoulaimane
Copy link
Member

No description provided.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @SSoulaimane! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + dmd#10071"

@SSoulaimane SSoulaimane force-pushed the cxxtest branch 2 times, most recently from 64547c1 to ae0a13b Compare June 22, 2019 17:10
@SSoulaimane
Copy link
Member Author

I also added two missing virtual function declarations to make the added tests succeed.

Copy link
Member

@ibuclaw ibuclaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@ibuclaw
Copy link
Member

ibuclaw commented Jun 26, 2019

I also added two missing virtual function declarations to make the added tests succeed.

Good to see it caught more problems. :-)

@dlang-bot dlang-bot merged commit bc6bb99 into dlang:master Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments