Skip to content

Conversation

@rainers
Copy link
Member

@rainers rainers commented Nov 1, 2019

As an alternative to #10506
Differences:

  • only enabled with -preview=dip1000
  • parameter storage type changed in semantics, not during parsing
  • scope only considered inferred, so not visible in header generation
  • in emitted by __traits(getParameterStorageClasses)
  • in added to mangling

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @rainers!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + dmd#10526"

@rainers
Copy link
Member Author

rainers commented Nov 2, 2019

Updated to keep in for the parameter in __traits(getParameterStorageClasses) (needs some patch in std.traits.extractParameterStorageClassFlags) and add it to the mangling (needs dlang/druntime#2847).

@MoonlightSentinel
Copy link
Contributor

Can this be closed given -preview=in?

@rainers
Copy link
Member Author

rainers commented Jul 9, 2020

I don't think the implementation of patching the code in the parser is correct, but I'm currently not planning to work on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants