Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.
/ druntime Public archive

Conversation

@rainers
Copy link
Member

@rainers rainers commented Nov 2, 2019

as a companion to dlang/dmd#10526

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @rainers!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + druntime#2847"

@thewilsonator
Copy link
Contributor

Whats with the accent in the commit message?

@rainers
Copy link
Member Author

rainers commented Nov 2, 2019

Whats with the accent in the commit message?

Oops, typo corrected.

@rainers rainers changed the title [PoC] demangle 'Ì' as in [PoC] demangle 'I' as in Nov 2, 2019
return dst[beg .. len];
case 'F': case 'U': case 'W': case 'V': case 'R': // TypeFunction
return parseTypeFunction( name );
case 'I': // TypeIdent (I LName)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So TypeIdent is not currently being used? Do you know what it was supposed to mean?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TypeIdentifier is part of the grammar, but it must be resolved to some other entity during semantics. See https://github.com/dlang/dmd/pull/10526/files#diff-ee89b0981cbb7f8ab2412e68a427d52aR100 for other similar "types".

@rainers rainers changed the title [PoC] demangle 'I' as in [PoC - do not merge] demangle 'I' as in Nov 3, 2019
@rainers
Copy link
Member Author

rainers commented Jul 9, 2020

Closing as a different implementation of in = scope const was merged.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants