[dmd-cxx] ctfeexpr: Backport fix for ICE in setValue at dinterpret.c:7046#11547
Merged
Geod24 merged 2 commits intodlang:dmd-cxxfrom Aug 11, 2020
Merged
[dmd-cxx] ctfeexpr: Backport fix for ICE in setValue at dinterpret.c:7046#11547Geod24 merged 2 commits intodlang:dmd-cxxfrom
Geod24 merged 2 commits intodlang:dmd-cxxfrom
Conversation
…7046 This was fixed in dlang#9282 (d6139e3).
Contributor
|
Thanks for your pull request, @ibuclaw! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "dmd-cxx + dmd#11547" |
Internally these would treat the cast same as a normal conversion from int[7] to int[], which allows code at CTFE to erroneously succeed where it would raise a SEGV at run-time.
thewilsonator
approved these changes
Aug 11, 2020
jpf91
pushed a commit
to D-Programming-GDC/gcc
that referenced
this pull request
Aug 21, 2020
Fixes an ICE in setValue at dmd/dinterpret.c:7046 This was originally seen when running the testsuite for a 16-bit target, however, it could be reproduced on 32-bit using long[] as well. Reviewed-on: dlang/dmd#11547 gcc/d/ChangeLog: * dmd/MERGE: Merge upstream dmd 1b5a53d01.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was fixed in #9282 (d6139e3).
See #11546 for adding the test to master.