Revert reinterpret cast introduced in #432, add ICE test case for 32-bit targets#11546
Merged
dlang-bot merged 2 commits intodlang:masterfrom Aug 11, 2020
Merged
Revert reinterpret cast introduced in #432, add ICE test case for 32-bit targets#11546dlang-bot merged 2 commits intodlang:masterfrom
dlang-bot merged 2 commits intodlang:masterfrom
Conversation
Contributor
|
Thanks for your pull request, @ibuclaw! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#11546" |
This was fixed in dlang#9282 (d6139e3).
Internally these would treat the cast same as a normal conversion from int[7] to int[], which allows code at CTFE to erroneously succeed where it would raise a SEGV at run-time.
ibuclaw
changed the title
thewilsonator
approved these changes
Aug 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An ICE was seen when running the testsuite for a 16-bit target. This ICE was indirectly fixed in #9282 (d6139e3), however you could the same ICE on 32-bit if
int[]was swapped withlong[].The reason why an ICE would happen is because the condition:
Would also inadvertently match
int[]andint[][2]on 16-bit,long[]andlong[][2]on 32-bit (and if there was support,cent[]andcent[][2]on 64-bit), and generate the wrong code for interpreting the assignment expression.However looking further into it, the code that introduced the ICE in #432 made it possible for reinterpret casts that would have invalid results at run-time to yield a sensible result at CTFE. So that change has been reverted too. The original reason for why it was necessary is no longer relevant any more.