Fix CTFE AA bug 6769, which is breaking the autotester.#432
Merged
WalterBright merged 3 commits intodlang:masterfrom Oct 6, 2011
Merged
Fix CTFE AA bug 6769, which is breaking the autotester.#432WalterBright merged 3 commits intodlang:masterfrom
WalterBright merged 3 commits intodlang:masterfrom
Conversation
added 3 commits
October 5, 2011 11:03
Undo the transformations which the inliner has done on the built-in AA properties. We really need to clean up the runtime, what it's doing is unnecessarily disgusting. A side-effect of the implementation is that casts from &int[7] to int[]* are now supported in CTFE.
A couple of minor changes is enough to make the code identical, allowing two functions to be completely removed. Also fixes a D1 bug in the type of .values and .keys.
WalterBright
added a commit
that referenced
this pull request
Oct 6, 2011
Fix CTFE AA bug 6769, which is breaking the autotester.
dlang-bot
added a commit
that referenced
this pull request
Aug 11, 2020
Revert reinterpret cast introduced in #432, add ICE test case for 32-bit targets merged-on-behalf-of: Nicholas Wilson <thewilsonator@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This whole thing is pretty much a workaround for the hacks used in the druntime implementation of template AAs. The hacks get exposed when you compile with -inline.
6769 [CTFE] AA.keys doesn't compile when -inline is used