Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid using byte constant loads #11648

Merged
merged 1 commit into from
Aug 30, 2020
Merged

avoid using byte constant loads #11648

merged 1 commit into from
Aug 30, 2020

Conversation

WalterBright
Copy link
Member

Loading parts of registers causes stalls, so try to avoid it with loading bytes. Extends #11644 for byte values.

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @WalterBright!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#11648"

@WalterBright
Copy link
Member Author

The buildkite and win32 errors appear to be unrelated to this PR.

@wilzbach
Copy link
Member

The buildkite and win32 errors appear to be unrelated to this PR.

Yes, see #11650

@wilzbach
Copy link
Member

The buildkite and win32 errors appear to be unrelated to this PR.

Buildkite "unbreaker": dlang/phobos#7611

@wilzbach wilzbach merged commit 29d72dd into dlang:master Aug 30, 2020
@WalterBright WalterBright deleted the movbyte branch August 30, 2020 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants