Revert "std.traits: Adapt unittest to pass with -preview=in"
#7611
Conversation
This reverts commit aca1e12.
|
Thanks for your pull request, @wilzbach! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + phobos#7611" |
|
This fixes the Buildkite failure. |
|
Ergh, sorry about this. Looks like my first commit was not as innocent as I thought, and the bug I encounter might not be |
|
Narrowed it down to https://issues.dlang.org/show_bug.cgi?id=21210 |
|
@Geod24 Would it be possible to make |
|
Force-merged as the two Windows machines on the auto-tester seem to be missing in action :/ |
|
@pbackus : That's not going to be of much help, since your code wouldn't compile with older DMD / LDC versions. |
|
@Geod24 I understand that. I'm okay with adding my own copy of |
Currently, isAssignable is true for non-copyable types, but should be false. This will be fixed in an upcoming Phobos release, so add a separate check for non-copyable types to avoid a regression when Phobos is upgraded. The symbol std.traits.isRvalueAssignable is currently private, but expected to become public in a future Phobos release. See also: - dlang issue 21210 - dlang/phobos#7611
|
Follow up #7612 |
Reverts #7609
Checking whether this PR broke the Buildkite sumtype build.