Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add MOVSXb, MOVSXw, MOVZXb, MOVZXw #11649

Merged
merged 1 commit into from
Aug 30, 2020
Merged

Conversation

WalterBright
Copy link
Member

Replace hardcoded numbers with mnemonics for these opcodes.

Saves me from constantly checking them.

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @WalterBright!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#11649"

@WalterBright
Copy link
Member Author

buildkite pbackus/sumtype appears to have been recently broken.

@wilzbach
Copy link
Member

buildkite pbackus/sumtype appears to have been recently broken.

See #11650

@wilzbach
Copy link
Member

buildkite pbackus/sumtype appears to have been recently broken.

Buildkite "unbreaker": dlang/phobos#7611

@WalterBright
Copy link
Member Author

Thanks @wilzbach good work!

@thewilsonator thewilsonator merged commit 5d9c9a8 into dlang:master Aug 30, 2020
@WalterBright WalterBright deleted the MOVSX branch August 30, 2020 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants