Fix the circle CI failures

[thewilsonator]

No description provided.

[dlang-bot]

Thanks for your pull request and interest in making D better, @thewilsonator! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

• My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
• My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
• I have provided a detailed rationale explaining my changes
• New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.

---

If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#11915"

[thewilsonator]

WTF this is green on master as of 71df3f6
rebasing onto a221c08

[thewilsonator]

I suspect #11823 is to blame

[thewilsonator]

Weird, when rebased on a037caa it results in a different error

1) when an interface method is not implemented
   it should report an error
core.exception.AssertError@/home/circleci/dmd/test/unit/interfaces/check_implementations_20861.d(51): 

----------------
src/core/exception.d:447 onAssertErrorMsg [0x5572ad0a2c2b]
src/core/exception.d:464 onUnittestErrorMsg [0x5572ad0a2cad]
src/core/exception.d:608 _d_unittest_msg [0x5572ad075d58]
/home/circleci/dmd/test/unit/interfaces/check_implementations_20861.d:51 void interfaces.check_implementations_20861.__unittest_L34_C5() [0x5572acdd62c6]
/home/circleci/dmd/test/test_results/runner.d:160 core.runtime.UnitTestResult runner.unitTestRunner() [0x5572acdf4c5c]
src/core/runtime.d:598 runModuleUnitTests [0x5572ad0a3132]
src/rt/dmain2.d:552 void rt.dmain2._d_run_main2(char[][], ulong, extern (C) int function(char[][])*).runAll() [0x5572ad078e35]
src/rt/dmain2.d:526 void rt.dmain2._d_run_main2(char[][], ulong, extern (C) int function(char[][])*).tryExec(scope void delegate()) [0x5572ad078db0]
src/rt/dmain2.d:585 _d_run_main2 [0x5572ad078d15]
src/rt/dmain2.d:379 _d_run_main [0x5572ad078a42]
/home/circleci/dmd/generated/linux/debug/64/../../../../../druntime/import/core/internal/entrypoint.d:29 main [0x5572ace0387d]
??:? __libc_start_main [0x7f2df838db96]
??:? _start [0x5572acda78e9]

232 tests, 1 failures

Failed tests:
/home/circleci/dmd/test/unit/interfaces/check_implementations_20861.d:51

[thewilsonator]

rebasing after #11823 , green?!?!???!!?

[RazvanN7]

So it's not #11823 ?

[thewilsonator]

I have no idea math this point. It was the first red pr on https://github.com/dlang/dmd/commits/master that exhibited the same error.

a221c08 had a build kite error fixed by dlang/ci#436

62898c2 was fixed by dlang/ci@565970c

[jacob-carlborg]

This might be a reason:

dmd/test/unit/lexer/location_offset.d

Line 7 in 9385296

import lexer.diagnostic_reporter : deinitializeFrontend;

deinitializeFrontend is never called.

[thewilsonator]

That seems like a reasonable explanation. Much better Than I've been able to come up with.

[jacob-carlborg]

For just using the lexer, initializing the fronted shouldn't be necessary. It's not done in the other lexer test: https://github.com/dlang/dmd/blob/master/test/unit/lexer/diagnostic_reporter.d.

[thewilsonator]

OK.

[thewilsonator]

Done.

[jacob-carlborg]

Looks good. All tests are passing.

Did it fail every time before? Can we trust it's good now?

[thewilsonator]

Did it fail every time before?

No it was intermittent

Can we trust it's good now?

Well the reversion of #11916 passed first time and so did this.