Skip to content

Comments

Don't build removed dlang-requests configuration#436

Merged
dlang-bot merged 1 commit intodlang:masterfrom
pbackus:patch-1
Oct 29, 2020
Merged

Don't build removed dlang-requests configuration#436
dlang-bot merged 1 commit intodlang:masterfrom
pbackus:patch-1

Conversation

@pbackus
Copy link
Contributor

@pbackus pbackus commented Oct 29, 2020

The configuration 'vibed' was removed from dlang-requests in version
2.0.0, so attempting to build it will always fail.


This is currently blocking all new PRs to dmd/druntime/phobos.

The configuration 'vibed' was removed from dlang-requests in version
2.0.0, so attempting to build it will always fail.
@dlang-bot
Copy link
Collaborator

Thanks for your pull request and interest in making D better, @pbackus! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants