Skip to content

Comments

Simplify std.traits.isBoolean#7684

Merged
dlang-bot merged 1 commit intodlang:masterfrom
n8sh:simplify-traits-isboolean
Nov 7, 2020
Merged

Simplify std.traits.isBoolean#7684
dlang-bot merged 1 commit intodlang:masterfrom
n8sh:simplify-traits-isboolean

Conversation

@n8sh
Copy link
Member

@n8sh n8sh commented Oct 28, 2020

No description provided.

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @n8sh!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#7684"

@pbackus
Copy link
Contributor

pbackus commented Oct 29, 2020

Buildkite failure is due to your branch missing the commits from #7678. Rebasing should fix it.

@n8sh n8sh force-pushed the simplify-traits-isboolean branch from 4d391f1 to db26b63 Compare October 29, 2020 07:16
@ljmf00
Copy link
Member

ljmf00 commented Oct 29, 2020

BooleanTypeOf check for alias this of type bool, can you do this with T : bool ?

struct B
{
    bool val;
    alias val this;
}

@pbackus
Copy link
Contributor

pbackus commented Oct 29, 2020

@ljmf00 This case is covered by the unit tests; take a look.

@pbackus
Copy link
Contributor

pbackus commented Oct 29, 2020

Now the Buildkite failure is due to the new release of dlang-requests breaking the CI script.

PR here: dlang/ci#436

@ljmf00
Copy link
Member

ljmf00 commented Oct 30, 2020

@ljmf00 This case is covered by the unit tests; take a look.

Yeah. Didn't know that SubTypeOf does that 👍

@dlang-bot dlang-bot merged commit 25348d6 into dlang:master Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants