Skip to content

test: Remove test case for issue 5305#13016

Merged
dlang-bot merged 1 commit intodlang:masterfrom
ibuclaw:rm-test5305
Aug 25, 2021
Merged

test: Remove test case for issue 5305#13016
dlang-bot merged 1 commit intodlang:masterfrom
ibuclaw:rm-test5305

Conversation

@ibuclaw
Copy link
Member

@ibuclaw ibuclaw commented Aug 25, 2021

This test is already covered in Phobos std.math

dlang/phobos#8210

This test is already covered in Phobos std.math
@dlang-bot
Copy link
Contributor

Thanks for your pull request, @ibuclaw!

Bugzilla references

Auto-close Bugzilla Severity Description
5305 normal Cannot take pointer to intrinsic function

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#13016"

@dlang-bot dlang-bot merged commit 8a62505 into dlang:master Aug 25, 2021
@ibuclaw ibuclaw deleted the rm-test5305 branch August 25, 2021 15:28
@Geod24
Copy link
Member

Geod24 commented Aug 26, 2021

The issue was not fixed BTW. It's just that std.math now wraps core.math, but we still can't take a pointer to an intrinsic.
See #5845

@ibuclaw
Copy link
Member Author

ibuclaw commented Aug 26, 2021

The issue was not fixed BTW. It's just that std.math now wraps core.math, but we still can't take a pointer to an intrinsic.
See #5845

Thanks, I remember that heated discussion well. The behaviour is correct for the same reason you can't take the address of enums, both don't exist in memory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments