Skip to content

std.math: Reference Issue 5305 in unittest taking pointer to function#8210

Merged
dlang-bot merged 1 commit intodlang:masterfrom
ibuclaw:issue5305
Aug 25, 2021
Merged

std.math: Reference Issue 5305 in unittest taking pointer to function#8210
dlang-bot merged 1 commit intodlang:masterfrom
ibuclaw:issue5305

Conversation

@ibuclaw
Copy link
Member

@ibuclaw ibuclaw commented Aug 25, 2021

Was going to move test from dmd testsuite here, but I see that it already exists.

@ibuclaw ibuclaw added the Review:Trivial typos, formatting, comments label Aug 25, 2021
@dlang-bot
Copy link
Contributor

Thanks for your pull request, @ibuclaw!

Bugzilla references

Auto-close Bugzilla Severity Description
5305 normal Cannot take pointer to intrinsic function

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#8210"

@dlang-bot dlang-bot merged commit 1cbbb84 into dlang:master Aug 25, 2021
@ibuclaw ibuclaw deleted the issue5305 branch August 25, 2021 19:36
@Geod24
Copy link
Member

Geod24 commented Aug 26, 2021

As mentioned in the DMD PR, this test is useless. It just test taking the address of a function, while the issue originally reported was about intrinsic. It should probably mention that this is a workaround.

@ibuclaw
Copy link
Member Author

ibuclaw commented Aug 26, 2021

As mentioned in the DMD PR, this test is useless. It just test taking the address of a function, while the issue originally reported was about intrinsic. It should probably mention that this is a workaround.

It originally failed because the intrinsic had no function definition. You can't take the address of something that doesn't exist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merge:auto-merge Review:Trivial typos, formatting, comments

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments