-
-
Notifications
You must be signed in to change notification settings - Fork 612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt default sc.ini
to MsCoff by default
#13611
Conversation
Thanks for your pull request and interest in making D better, @MoonlightSentinel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#13611" |
50a692c
to
465122a
Compare
Ensures that Phobos / LibC buffering doesn't mess with the output ordering as the executed program will flush when exiting
The old configuration still used OPTLINk for `-m32` which obviously doesn't support MsCoff files. Also added a test file that builds and executes a small program using the configurations in `ini` and `build.d` (as allmost all other tests run with `-conf=`).
465122a
to
b1470ac
Compare
Ready for review |
While you're working on this area of dmd it might be good to sort out dmd's behaviour WRT lib. If I understand the bug correctly it actually overwrites the LIB environment variable rather than appending to it. |
I think so. Appending the correct path to |
The old configuration still used OPTLINk for
-m32
which obviously doesn't support MsCoff files. Also added a test file that builds and executes a small program using the configurations inini
andbuild.d
(as allmost all other tests run with-conf=
).CC @thewilsonator