Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt default sc.ini to MsCoff by default #13611

Merged
merged 2 commits into from
Feb 8, 2022

Conversation

MoonlightSentinel
Copy link
Contributor

@MoonlightSentinel MoonlightSentinel commented Feb 4, 2022

The old configuration still used OPTLINk for -m32 which obviously doesn't support MsCoff files. Also added a test file that builds and executes a small program using the configurations in ini and build.d (as allmost all other tests run with -conf=).

CC @thewilsonator

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @MoonlightSentinel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#13611"

@MoonlightSentinel MoonlightSentinel force-pushed the config-windows branch 10 times, most recently from 50a692c to 465122a Compare February 5, 2022 19:16
Ensures that Phobos / LibC buffering doesn't mess with the output ordering
as the executed program will flush when exiting
The old configuration still used OPTLINk for `-m32` which obviously
doesn't support MsCoff files. Also added a test file that builds and
executes a small program using the configurations in `ini` and `build.d`
(as allmost all  other tests run with `-conf=`).
@MoonlightSentinel MoonlightSentinel marked this pull request as ready for review February 5, 2022 20:10
@MoonlightSentinel MoonlightSentinel marked this pull request as draft February 5, 2022 21:00
@MoonlightSentinel MoonlightSentinel marked this pull request as ready for review February 8, 2022 00:24
@MoonlightSentinel
Copy link
Contributor Author

Ready for review

@maxhaton
Copy link
Member

maxhaton commented Feb 8, 2022

While you're working on this area of dmd it might be good to sort out dmd's behaviour WRT lib. If I understand the bug correctly it actually overwrites the LIB environment variable rather than appending to it.

@MoonlightSentinel
Copy link
Contributor Author

I think so. Appending the correct path to LIB would enable the linker to find the correct libraries but still fail because dmd then passes MsCoff files to OPTLINK (configured by LINKCMD)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants