Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove workaround for the broken sc.ini on Windows #496

Merged

Conversation

MoonlightSentinel
Copy link
Contributor

The configuration file was fixed upstream by dlang/dmd#13611

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @MoonlightSentinel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@MoonlightSentinel
Copy link
Contributor Author

Seems like I've found a bug in Github Actions' reuseable workflows. Starting the tests for this PR failed with the following error:

error parsing called workflow "./.github/workflows/build_release_template.yml@"

But the file exists in both master and the PR branch (which is based on current master). The workflow also started correctly for the push to master...

Reported here

The configuration files was fixed upstream by DMD PR 13611
@MoonlightSentinel
Copy link
Contributor Author

GA works now and all tests passed

@thewilsonator thewilsonator merged commit f318a60 into dlang:master Feb 11, 2022
@MoonlightSentinel MoonlightSentinel deleted the remove-windows-workaround branch February 11, 2022 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants