Translate _d_newarray{mTX, miTX, Op} to a single template#15819
Merged
RazvanN7 merged 1 commit intodlang:masterfrom Nov 17, 2023
Merged
Translate _d_newarray{mTX, miTX, Op} to a single template#15819RazvanN7 merged 1 commit intodlang:masterfrom
_d_newarray{mTX, miTX, Op} to a single template#15819RazvanN7 merged 1 commit intodlang:masterfrom
Conversation
Contributor
|
Thanks for your pull request, @teodutu! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#15819" |
6884ad9 to
a6e64d3
Compare
_d_newarray{mTX, miTX, Op} to a single template_d_newarray{mTX, miTX, Op} to a single template
a6e64d3 to
095f1ac
Compare
095f1ac to
2cc7ed8
Compare
Member
Author
|
I'll improve the hook and its nested function in the coming days. Up to now, I just wanted something that works and hopefully passes the CI tests. |
84975ff to
78e2c8f
Compare
Contributor
|
Looks like some profile gc tests need to be updated. |
78bb38c to
90dfb5b
Compare
Contributor
|
@teodutu maybe also add a changelog entry to be consistent with the previously templated hook? |
693f694 to
c6122bf
Compare
- Move code for `_d_newarraymTX` to `core.internal.array.construction` - Remove `_d_newarraymiTX` and `_d_newarraymOp` - Add unittests for `_d_newarraymTX` - Move lowering to `_d_newarraymTX` to the semantic phase - Inline the lowering when inlining `NewExp`s - Add changelog entry about the new hook Signed-off-by: Teodor Dutu <teodor.dutu@gmail.com>
c6122bf to
e9d70fe
Compare
Member
Author
|
Done @RazvanN7. |
RazvanN7
approved these changes
Nov 17, 2023
Contributor
|
This caused a regression: https://issues.dlang.org/show_bug.cgi?id=24436 Since #16097 the regression does not happen any more for me. |
nybzmr
added a commit
to nybzmr/dmd
that referenced
this pull request
Mar 19, 2025
…EWARRAYMITX, TRACENEWARRAYMTX and TRACENEWARRAYMITX
thewilsonator
pushed a commit
that referenced
this pull request
Mar 19, 2025
* Remove RTLSYM for Translation PR #15819: Removed NEWARRAYMITX, NEWARRAYMITX, TRACENEWARRAYMTX and TRACENEWARRAYMITX * Remove RTLSYM for Translation PR #15299: Removed NEWARRAYT, NEWARRAYIT, TRACENEWARRAYT and TRACENEWARRAYIT * Remove RTLSYM for Translation PR #14837: Removed NEWCLASS, TRACENEWCLASS * Remove RTLSYM for Translation PR #14664: Removed NEWITEMT, NEWITEMIT, TRACENEWITEMT and TRACENEWITEMIT * Remove RTLSYM for Translation PR #14550: Removed ARRAYCATNTX, ARRAYCATT, TRACEARRAYCATNTX and TRACEARRAYCATT * Remove RTLSYM for Translation PR #14382: Removed ARRAYSETASSIGN * Remove RTLSYM for Translation PR #14310: Removed ARRAYASSIGN * Remove RTLSYM for Translation PR #13495: Removed ARRAYAPPENDT, ARRAYAPPENDCTX, TRACEARRAYAPPENDT and TRACEARRAYAPPENDCTX
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_d_newarraymTXtocore.internal.array.construction_d_newarraymiTXand_d_newarraymOp_d_newarraymTX_d_newarraymTXto the semantic phaseNewExps