core.internal.array.duplication: Replace _d_newarrayU with template in _dup#16097
Merged
RazvanN7 merged 1 commit intodlang:masterfrom Jan 27, 2024
Merged
core.internal.array.duplication: Replace _d_newarrayU with template in _dup#16097RazvanN7 merged 1 commit intodlang:masterfrom
_d_newarrayU with template in _dup#16097RazvanN7 merged 1 commit intodlang:masterfrom
Conversation
Contributor
|
Thanks for your pull request, @teodutu! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#16097" |
teodutu
force-pushed
the
_d_newarrayU-dup
branch
3 times, most recently
from
be75566 to
c3aa1a5
Compare
- Only use the `pure nothrow` wrapper `_d_newarrayUPureNothrow` for the
`pure nothrow` `_dup`
- Unqualify the template type given to `_d_newarrayU`. The initial
template was relying on this unqualification being done by the compiler,
but now it's called from `_dup`
- Fix `TypeInfoSize` to only account for type `struct`s
- Cannot remove `_d_newarray{iT,T,U}` from `rt.lifetime` because they're used by `aaA.d`
Signed-off-by: Teodor Dutu <teodor.dutu@gmail.com>
teodutu
force-pushed
the
_d_newarrayU-dup
branch
from
c3aa1a5 to
999011d
Compare
dkorpel
approved these changes
Jan 27, 2024
RazvanN7
approved these changes
Jan 27, 2024
Member
|
This caused a regression: https://issues.dlang.org/show_bug.cgi?id=24453 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pure nothrowwrapper_d_newarrayUPureNothrowfor thepure nothrow_dup_d_newarrayU. The initial template relied on this unqualification being done by the compiler, but now it's called from_dupTypeInfoSizeto only account for typestructs_d_newarray{iT,T,U}fromrt.lifetimebecause they're used byaaA.d