More conservative fix for issue 12900 - Wrong code in IfStatement condition Expression #3685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kenji, thanks for finding a better way. Can you add the test case here? |
|
Added a bit complex assert in |
WalterBright
added a commit
that referenced
this pull request
Jun 25, 2014
More conservative fix for issue 12900 - Wrong code in IfStatement condition Expression
Trass3r
added a commit
to Trass3r/ldc
that referenced
this pull request
Jun 29, 2014
redstar
added a commit
to ldc-developers/ldc
that referenced
this pull request
Jun 29, 2014
Add changes from dlang/dmd#3685
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvement for the PR #3662.
t1->implicitConvTo(t2) >= MATCHconsthas a known problem (eg. issue 5363).*&ex to exand&*ex to exshould be handled in same way.