Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid invalid *&ex -> ex optimizations. #649

Merged
merged 1 commit into from
Jun 29, 2014

Conversation

dnadlinger
Copy link
Member

This is a back-port of dlang/dmd#3662 (commit 4da4da1), and fixes compilation of:

struct Foo { char[1] bar; }
bool checkBar(Foo* foo) { return true && *foo.bar.ptr; }

This is a back-port of dlang/dmd#3662
(commit 4da4da1), and fixes compilation of:
---
struct Foo { char[1] bar; }
bool checkBar(Foo* foo) { return true && *foo.bar.ptr; }
---
@Trass3r
Copy link
Contributor

Trass3r commented Jun 28, 2014

There is a followup PR dlang/dmd#3685

@dnadlinger
Copy link
Member Author

@Trass3r: I'm working on something else right now – do you have time to merge the rest of the changes?

@Trass3r
Copy link
Contributor

Trass3r commented Jun 28, 2014

Yes done that. It fixes the assertion I got.

@redstar
Copy link
Member

redstar commented Jun 29, 2014

Could you create a pull request for it?

redstar added a commit that referenced this pull request Jun 29, 2014
Avoid invalid *&ex -> ex optimizations.
@redstar redstar merged commit 806babe into ldc-developers:master Jun 29, 2014
@dnadlinger dnadlinger deleted the backport-dmd-3662 branch June 29, 2014 09:04
redstar pushed a commit that referenced this pull request Sep 27, 2014
fix Issue 11378 - implicit runtime initialization/finalization is broken
redstar pushed a commit that referenced this pull request Sep 27, 2014
fix Issue 11378 - implicit runtime initialization/finalization is broken
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants