Skip to content

At least GNU make 4.1 on Linux Mint introduces a space in a variable …#6052

Merged
andralex merged 1 commit intodlang:masterfrom
andralex:make
Aug 12, 2016
Merged

At least GNU make 4.1 on Linux Mint introduces a space in a variable …#6052
andralex merged 1 commit intodlang:masterfrom
andralex:make

Conversation

@andralex
Copy link
Member

…definition followed by a space then a comment

…definition followed by a space then a comment
@wilzbach
Copy link
Contributor

See this comment for reference & explanation #6022 (comment)

#6052 also fixes a typo, could you please pull it and close the other :o). -- Andrei

For obvious reasons I don't have merge rights here, but I am pretty sure that someone else will quickly pull this as well.

@andralex
Copy link
Member Author

@wilzbach sent you an invite

@wilzbach
Copy link
Contributor

@wilzbach sent you an invite

thanks a lot, but it seems AutoTester doesn't like me & you need to wait:

image

@andralex
Copy link
Member Author

I'll irregularly pull this in the interest of speed, I assume you'd have done the same and do not contest the pull.

@andralex andralex merged commit 641b52d into dlang:master Aug 12, 2016
@wilzbach
Copy link
Contributor

wilzbach commented Aug 12, 2016

I'll irregularly pull this in the interest of speed, I assume you'd have done the same and do not contest the pull.

Yep ;-)

Your tests failed on CircleCI

that's unrelated and we seem to hit the rate-limit of the API again. I think there's a simple fix for it though

++ curl -fsSL https://api.github.com/repos/dlang/dmd/pulls/6052
++ jq -r .base.ref
curl: (22) The requested URL returned error: 403

edit: see #6053

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants