Skip to content

[CircleCi] add more soft fallbacks#6053

Merged
MartinNowak merged 1 commit intodlang:masterfrom
wilzbach:ratelimit-circle
Mar 16, 2017
Merged

[CircleCi] add more soft fallbacks#6053
MartinNowak merged 1 commit intodlang:masterfrom
wilzbach:ratelimit-circle

Conversation

@wilzbach
Copy link
Contributor

@wilzbach wilzbach commented Aug 12, 2016

this should set master as default branch in case we run into issues with the Github API rate limit.

@MartinNowak do you have better ideas? can we maybe expose a oauth token of a dummy account, s.t. we have a higher rate limit?

e.g. setting https://circleci.com/gh/dlang/dmd/edit#env-vars

and then using one of the variants here

curl -u "$OAUTH-TOKEN:x-oauth-basic" https://api.github.com/user
curl -H "Authorization: token $OAUTH-TOKEN" https://api.github.com
curl https://api.github.com/?access_token=$OAUTH-TOKEN

@dlang-bot
Copy link
Contributor

@wilzbach, thanks for your PR! By analyzing the annotation information on this pull request, we identified @MartinNowak to be a potential reviewer

@wilzbach wilzbach changed the title Set a default branch on CircleCi in case we hit the API rate limit [WIP] Set a default branch on CircleCi in case we hit the API rate limit Aug 12, 2016
@wilzbach wilzbach force-pushed the ratelimit-circle branch 2 times, most recently from c9c93a9 to cc3217b Compare February 16, 2017 14:19
@wilzbach wilzbach changed the title [WIP] Set a default branch on CircleCi in case we hit the API rate limit [CircleCi] add more fallbacks Feb 16, 2017
@wilzbach wilzbach changed the title [CircleCi] add more fallbacks [CircleCi] add more soft fallbacks Feb 16, 2017
@WalterBright
Copy link
Member

I'd pull this, but I have no experience with this sort of thing.

@MartinNowak MartinNowak merged commit 259c1b6 into dlang:master Mar 16, 2017
@wilzbach wilzbach deleted the ratelimit-circle branch December 19, 2017 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments