Skip to content

merge scope/DIP1000 preview #6388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MartinNowak merged 54 commits into from
Dec 31, 2016
Merged

merge scope/DIP1000 preview #6388

MartinNowak merged 54 commits into from
Dec 31, 2016

Conversation

@MartinNowak
Copy link
Member

@MartinNowak MartinNowak commented Dec 30, 2016

This is intended as feature preview (hidden behind a switch). The implementation might still have a few bugs, but we want to test the design with a slightly broader audience.

WalterBright and others added 30 commits November 1, 2016 02:13
@WalterBright
return scope: first support
0de3e4d
@WalterBright
check assignments to globals
62be2fb
@WalterBright
allow 'return scope' parameters that return by 'ref'
eb4d6fe
@WalterBright
fix Issue 14238 - DIP25: escape checks can be circumvented with delegate
7c3e47a
@WalterBright
create EscapeByResults struct
56b904c
@WalterBright
fix Issue 15544 - Escaping fields to a heap delegate must be disallow…
e61378a 
…ed in @safe code
@WalterBright
fix Issue 8838 - Slicing static arrays should be considered unsafe (@…
66187b5 
…System)
@WalterBright
add parameterStorageClass()
128f3fa
@WalterBright
add inference of 'scope' for parameters for inferrable functions
d612c94
@WalterBright
refactor: add Parameter.isCovariant()
57a0b21
@WalterBright
add 'scope' support to 'this'
1cce2ee
@WalterBright
add lifetime checks
75647f5
@WalterBright
fix checking for struct fields
6d4de39
@MartinNowak
Merge remote-tracking branch 'upstream/master' into scope
9e6f8a7
@WalterBright
know when to not infer 'scope'
225c713
@MartinNowak
Merge pull request #5972 from WalterBright/return-scope
20add0d 
return scope: first support
@WalterBright
allow taking address of local in @safe code
5928249
@WalterBright
treat delegate as argument in delegate call
f72d308
@WalterBright
allow 'return' attribute on nested functions
b8df860
@WalterBright
infer 'return' for nested functions
2f733d3
@WalterBright
disallow taking address of scope local variable
d6bd697
@MartinNowak
Merge pull request #6253 from WalterBright/addr-of-local
a98e6ed 
[scope] allow taking address of local in @safe code
@WalterBright
refactor: .safe to .vsafe
f86d9fb
@MartinNowak
Merge pull request #6316 from WalterBright/vsafe
1057976 
refactor: .safe to .vsafe
@WalterBright
sync printfs with master
dbf45b7
@WalterBright
revert changes to closure detection
c5bed82
@andralex
Merge pull request #6317 from WalterBright/scope-printf
ac6f655 
sync printfs with master
@MartinNowak
Merge pull request #6319 from WalterBright/scope-closure
2846084 
revert changes to closure detection
@WalterBright
infer return for 'maybescope' too
06eaf84
@MartinNowak
Merge pull request #6321 from WalterBright/infer-return
5e78f45 
infer return for 'maybescope' too
MartinNowak and others added 18 commits December 18, 2016 00:10
@MartinNowak
Merge pull request #6329 from WalterBright/static-array-scope
20cd1f3 
treat &a[i] same as &a if 'a' is static array
@WalterBright
track assignment to static array member
d272c56
@MartinNowak
Merge pull request #6332 from WalterBright/static-array-assign
53693e7 
track assignment to static array member
@WalterBright @MartinNowak
stop escaping via initialization of 'this'
1e6fdfa
@MartinNowak
Merge pull request #6331 from WalterBright/param-this
f0970d4 
stop escaping via initialization of 'this'
@MartinNowak
restrict escape this check to scope preview
4ba32c1
@MartinNowak
Merge pull request #6340 from MartinNowak/fix_this_escape
9e2d8f7 
restrict escape this check to scope preview
@MartinNowak
Merge pull request #6279 from WalterBright/fix16747
0117027 
fix Issue 16747 - Cannot have stack allocated classes in @safe code
@WalterBright
Merge pull request #6339 from MartinNowak/fix16747
1dc8c17 
Merge pull request #6279 from WalterBright/fix16747
@WalterBright @MartinNowak
fix improper determination of 'return this' status
fc12c64
@dlang-bot
Merge pull request #6330 from WalterBright/return-this
bd0dec2 
fix improper determination of 'return this' status
@WalterBright
lvalues should be checked for escapes, not rvalues
e5f9ef7
@MartinNowak
Merge pull request #6363 from WalterBright/fix17029
c8d9e33 
fix Issue 17029 - [Reg 2.072] scope variable may not be returned
# Conflicts:
#	src/escape.d
@MartinNowak
Merge pull request #6369 from MartinNowak/fix17029
f3a239f 
Merge pull request #6363 from WalterBright/fix17029
@MartinNowak
Merge remote-tracking branch 'upstream/master' into merge_master_into…
491b7cc 
…_scope

Conflicts:
	src/escape.d
	src/func.d
	src/globals.d
	src/mars.d
	src/mtype.d
	src/statementsem.d
	test/fail_compilation/test16193.d
@MartinNowak
Merge pull request #6371 from MartinNowak/merge_master_into_scope
cd0640e 
Merge remote-tracking branch 'upstream/master' into merge_master_into_scope
@MartinNowak
add regression test for leaked scope check
e0ac0a8 
- was active without any flags (-transition=safe)
- implementation of check w/ -transition=safe still seems incorrect
@MartinNowak
Merge pull request #6365 from WalterBright/lvalue-esc
e46873f 
lvalues should be checked for escapes, not rvalues
@dlang-bot
Copy link
Contributor

dlang-bot commented Dec 30, 2016

Fix Bugzilla Description
✓ 8838 Slicing static arrays should be considered unsafe (@System)
✓ 14238 DIP25: escape checks can be circumvented with delegate
✓ 15544 Escaping fields to a heap delegate must be disallowed in @safe code

@MartinNowak MartinNowak merged commit f715090 into master Dec 31, 2016
@MartinNowak MartinNowak deleted the scope branch December 31, 2016 18:20
@WalterBright
Copy link
Member

WalterBright commented Dec 31, 2016

thanks, @MartinNowak

@MartinNowak
Copy link
Member Author

MartinNowak commented Dec 31, 2016 •
edited
Loading

Can we please keep using a feature branch for all the changes and fixes until 2.074? Delete all the scope branches in the dlang repo now, but we can easily recreated them.

@WalterBright
Copy link
Member

WalterBright commented Dec 31, 2016

why? Now it's just conventional bug reports and fixes for dip1000 issues.

@nordlow
Copy link
Contributor

nordlow commented Jan 1, 2017 •
edited
Loading

Please see: http://forum.dlang.org/post/hiaabptvovfnzwtqdodf@forum.dlang.org

@CyberShadow
Copy link
Member

CyberShadow commented Jul 2, 2017

This pull request introduced a regression:
https://issues.dlang.org/show_bug.cgi?id=17445

@WalterBright
Copy link
Member

WalterBright commented Jul 2, 2017

This pull request introduced a regression:

An example of why I don't like feature branches - somewhere in 1500 lines of changes is the problem.

@CyberShadow
Copy link
Member

CyberShadow commented Jul 2, 2017

It's usually not a problem to bisect inside the branch, it's just that Digger is not set up to do it by default.

@CyberShadow
Copy link
Member

CyberShadow commented Jul 2, 2017

Bisected it down to the scope PR and commit -> #5972 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@MartinNowak @dlang-bot @WalterBright @nordlow @CyberShadow @andralex