Skip to content

Comments

Move logic for determining extern(System) to Target#6751

Merged
dlang-bot merged 2 commits intodlang:masterfrom
ibuclaw:sys-linkage
May 7, 2017
Merged

Move logic for determining extern(System) to Target#6751
dlang-bot merged 2 commits intodlang:masterfrom
ibuclaw:sys-linkage

Conversation

@ibuclaw
Copy link
Member

@ibuclaw ibuclaw commented May 7, 2017

No description provided.

@dlang-bot dlang-bot merged commit 6ca78a1 into dlang:master May 7, 2017
@ibuclaw ibuclaw deleted the sys-linkage branch May 9, 2017 21:42
import ddmd.root.outbuffer;
import ddmd.root.rmem;
import ddmd.root.rootobject;
import ddmd.target;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, adding this line brings in the rest of the compiler, including the backend, as a dependency on this module. The parser was separate from most of the rest of the compiler in this PR: #6625.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Erm, you're too late.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Erm, you're too late.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know, but that doesn't mean it can't be fixed now.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I mean that the fix was done two days ago, and should have gone in yesterday.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently the Jenkins ci is broken and preventing auto merges. In any case you are making a claim that falls on deaf ears because the fix was already made available 24 hours ago.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind linking to the PR or commit that fixed this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tried to look at the PR and commit history to find the fix, but was unable to find it.

Copy link
Contributor

@jpf91 jpf91 May 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants