Add LINKsystem, remove dependency on Target from the parser#6764
Merged
WalterBright merged 2 commits intodlang:masterfrom May 11, 2017
Merged
Add LINKsystem, remove dependency on Target from the parser#6764WalterBright merged 2 commits intodlang:masterfrom
WalterBright merged 2 commits intodlang:masterfrom
Conversation
src/ddmd/attrib.d
Outdated
| super(decl); | ||
| //printf("LinkDeclaration(linkage = %d, decl = %p)\n", p, decl); | ||
| linkage = p; | ||
| linkage = (p != LINKsystem) ? p : Target.systemLinkage(); |
Member
There was a problem hiding this comment.
This would flow better as:
(p == LINKsystem) ? Target.systemLinkage() : p;
Member
Author
There was a problem hiding this comment.
Yeah, I did, but then I remembered some obscure optimization detail that dmd considers the first branch as hot. Maybe that's one micro-optimization too far though. ;-)
Member
Author
|
Rebased. |
Contributor
|
I don't like that we're discarding information as we build the parse tree, but it is the same with the current version. |
Member
Author
Mehhh... At least two errors have improved. If I were thinking about having the frontend as a library, you would have a point though. |
Member
Author
|
Is someone going to fix Jenkins, or... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As requested by @yebblies - I don't think this should leak to the glue, if it does, then that should be plugged.