fix Issue 17492 - [REG 2.066] [ICE] AssertError@ddmd/dclass.d(1007): … #6964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request, @WalterBright! Bugzilla references
|
…Assertion failure
ibuclaw
reviewed
Jul 5, 2017
| printf("this = %p %s\n", this, this.toPrettyChars()); | ||
| printf("type = %d sym = %p, %s\n", type.ty, cd, cd.toPrettyChars()); | ||
| } | ||
| error("already exists at %s. Perhaps in another function with the same name?", cd.loc.toChars()); |
There was a problem hiding this comment.
Maybe split this into an error an errorSupplemental?
error("already exists, perhaps in another function with the same name.");
errorSupplemental(cd.loc, "previous declaration found here.");
Rather than formating the location into the error string.
|
Can one create two functions with the same prototype without an error ? Which purpose ? |
Yes. This is an old issue. |
Also responsible for duplicate manglings https://issues.dlang.org/show_bug.cgi?id=17352. |
tramker
pushed a commit
to tramker/dmd
that referenced
this pull request
Dec 14, 2017
fix Issue 17492 - [REG 2.066] [ICE] AssertError@ddmd/dclass.d(1007): … merged-on-behalf-of: Martin Nowak <code@dawg.eu> cherry-picked-by: Martin Krejcirik <mk@krej.cz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…Assertion failure