Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 19024 - [ICE] AssertError@dmd/dsymbolsem.d(4317): Assertion failure #8428

Merged
merged 2 commits into from
Jul 2, 2018

Conversation

ibuclaw
Copy link
Member

@ibuclaw ibuclaw commented Jul 1, 2018

Same fix as #6964, but for structs.

@ibuclaw ibuclaw added Severity:Regression PRs that fix regressions Severity:Bug Fix labels Jul 1, 2018
@dlang-bot
Copy link
Contributor

Thanks for your pull request, @ibuclaw!

Bugzilla references

Auto-close Bugzilla Severity Description
14739 critical Immutable alias to template triggers dmd assert
19024 regression [REG 2.081-beta] AssertError@dmd/dsymbolsem.d(4317): Assertion failure

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "stable + dmd#8428"

@wilzbach wilzbach merged commit 36f2383 into dlang:stable Jul 2, 2018
@wilzbach
Copy link
Member

wilzbach commented Jul 2, 2018

Merging, s.t. this critical regression fix can still be part of the 2.081 release.

@ibuclaw ibuclaw deleted the reg12378 branch July 2, 2018 06:14
@ibuclaw
Copy link
Member Author

ibuclaw commented Jul 2, 2018

@wilzbach - I guess self merge means the bot won't auto-close the issues?

@wilzbach
Copy link
Member

wilzbach commented Jul 2, 2018

No, it has nothing todo with this.
The Bugzilla integration simply only closes issues when they are merged into master (people complained because they were getting many duplicated emails).
However, imho it's probably better to use "stable" instead as this will avoid the awkward situation that last-minute fixes aren't shown in the changelog (the changelog filters for only fixed issues).
OTOH it would also be awkward if the issues merged from master don't get auto-closed.
Anyhow, we have to replace this bit with the dlang-bot soonish as the GitHub Services are deprecated.

In case someone is interested here's how the config looks at the moment:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants