Skip to content

Comments

Fix Issue 17684 - [REG 2.062] static alias this (Part 2)#7070

Merged
dlang-bot merged 1 commit intodlang:stablefrom
JinShil:stable
Aug 7, 2017
Merged

Fix Issue 17684 - [REG 2.062] static alias this (Part 2)#7070
dlang-bot merged 1 commit intodlang:stablefrom
JinShil:stable

Conversation

@JinShil
Copy link
Contributor

@JinShil JinShil commented Aug 7, 2017

Follow up to #7055.

I discovered that the implementation was still incomplete, and static alias this would not work with binary expressions (e.g. ==). This attempts to fix that.

I also added more tests in an attempt to be more thorough.

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @JinShil! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.

Some tips to help speed things up:

  • smaller, focused PRs are easier to review than big ones

  • try not to mix up refactoring or style changes with bug fixes or feature enhancements

  • provide helpful commit messages explaining the rationale behind each change

Bear in mind that large or tricky changes may require multiple rounds of review and revision.

Please see CONTRIBUTING.md for more information.

Bugzilla references

Auto-close Bugzilla Description
17684 [REG 2.062] static alias this bug or incomplete implementation?

Some formatting and comments for expression.d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants