Skip to content

Comments

Fix Issue 17684 - [REG 2.062] static alias this (Part 3)#7106

Merged
WalterBright merged 1 commit intodlang:stablefrom
JinShil:static_alias_this_3
Aug 30, 2017
Merged

Fix Issue 17684 - [REG 2.062] static alias this (Part 3)#7106
WalterBright merged 1 commit intodlang:stablefrom
JinShil:static_alias_this_3

Conversation

@JinShil
Copy link
Contributor

@JinShil JinShil commented Aug 28, 2017

Followup to #7055 and #7070

The current implementation does not work for the following:

  • && and || expressions
  • ! expressions
  • return statements

This PR fixes those.

Tests were refactored to reduce redundancy and test for the features above.

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @JinShil! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.

Some tips to help speed things up:

  • smaller, focused PRs are easier to review than big ones

  • try not to mix up refactoring or style changes with bug fixes or feature enhancements

  • provide helpful commit messages explaining the rationale behind each change

Bear in mind that large or tricky changes may require multiple rounds of review and revision.

Please see CONTRIBUTING.md for more information.

Bugzilla references

Auto-close Bugzilla Description
17684 [REG 2.062] static alias this bug or incomplete implementation?

@ibuclaw
Copy link
Member

ibuclaw commented Aug 29, 2017

Seems reasonable to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants