Skip to content

Conversation

@wilzbach
Copy link
Contributor

@wilzbach wilzbach commented Dec 9, 2017

This will probably take a couple of hops again. Let's hope for the best...

@dlang-bot dlang-bot added the Review:WIP Work In Progress - not ready for review or pulling label Dec 9, 2017
@dlang-bot
Copy link
Contributor

dlang-bot commented Dec 9, 2017

Thanks for your pull request, @wilzbach!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + dmd#7414"

@wilzbach
Copy link
Contributor Author

Error on line 8: expecting target : dependencies

Looks like some patching error? :/

@wilzbach
Copy link
Contributor Author

Looks like some patching error? :/

Yep -> https://github.com/braddr/at-client/blob/master/src/diff-dmd-win64.diff
We should really get rid of these :/

@wilzbach
Copy link
Contributor Author

This is blocked on braddr/at-client#8 due to auto-tester's patching :/

@wilzbach
Copy link
Contributor Author

This is now failing with:

..\generated\windows\release\32\dmd.obj(dmd) 
 Error 42: Symbol Undefined ?out_config_debug@@YAX_N000000@Z
Error: linker exited with status 1

Has anyone seen this before?

@wilzbach wilzbach removed Merge:Blocked Review:WIP Work In Progress - not ready for review or pulling labels Jun 27, 2018
@jacob-carlborg
Copy link
Contributor

Unless you already figured this out, out_config_debug is defined in dmd/backend/backconfig.c, only when the C preprocessor macro DEBUG is defined. It's called from backend_init in a debug statement in dmd/dmsc.d.

@wilzbach wilzbach changed the title [WIP] Experiment with testing unittest on Windows Experiment with testing unittest on Windows Dec 31, 2018
@wilzbach
Copy link
Contributor Author

Looks like this one was "healed" by the DMD backend conversion to D (:


unittest:
$(DMDMAKE) "OPT=-o" "DEBUG=" "DDEBUG=-debug -g -unittest -cov" "DOPT=" "LFLAGS=-L/ma/co/delexe/la" $(TARGETEXE)
$(DMDMAKE) "OPT=-o" "DEBUG=" "DDEBUG=-g -unittest -cov" "DOPT=" "LFLAGS=-L/ma/co/delexe/la" $(TARGETEXE)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Debug builds fail also on Linux at the moment: #7528

@wilzbach
Copy link
Contributor Author

wilzbach commented Jan 8, 2019

CC @thewilsonator this is ready to go and passing on the CIs.

@thewilsonator
Copy link
Contributor

Auto-merge toggled on

@thewilsonator
Copy link
Contributor

Auto-merge toggled off

@thewilsonator
Copy link
Contributor

Its failing agin now.

@wilzbach wilzbach mentioned this pull request Feb 9, 2019
@rainers
Copy link
Member

rainers commented Aug 9, 2019

removing auto-merge because the unittest is failing. Running dmd without args is considered an error, something like dmd --version should be used instead.

@MoonlightSentinel
Copy link
Contributor

MoonlightSentinel commented Dec 2, 2019

This could be closed beceause #10612 enabled unittesting on windows

@wilzbach
Copy link
Contributor Author

wilzbach commented Dec 2, 2019

Thanks!

@wilzbach wilzbach closed this Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants