-
-
Notifications
You must be signed in to change notification settings - Fork 672
Experiment with testing unittest on Windows
#7414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for your pull request, @wilzbach! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + dmd#7414" |
Looks like some patching error? :/ |
70b14fd to
a5edf00
Compare
Yep -> https://github.com/braddr/at-client/blob/master/src/diff-dmd-win64.diff |
|
This is blocked on braddr/at-client#8 due to auto-tester's patching :/ |
|
This is now failing with: Has anyone seen this before? |
|
Unless you already figured this out, |
4ddeb49 to
daef304
Compare
unittest on Windowsunittest on Windows
|
Looks like this one was "healed" by the DMD backend conversion to D (: |
|
|
||
| unittest: | ||
| $(DMDMAKE) "OPT=-o" "DEBUG=" "DDEBUG=-debug -g -unittest -cov" "DOPT=" "LFLAGS=-L/ma/co/delexe/la" $(TARGETEXE) | ||
| $(DMDMAKE) "OPT=-o" "DEBUG=" "DDEBUG=-g -unittest -cov" "DOPT=" "LFLAGS=-L/ma/co/delexe/la" $(TARGETEXE) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Debug builds fail also on Linux at the moment: #7528
|
CC @thewilsonator this is ready to go and passing on the CIs. |
|
Auto-merge toggled on |
|
Auto-merge toggled off |
|
Its failing agin now. |
|
removing auto-merge because the unittest is failing. Running dmd without args is considered an error, something like |
|
This could be closed beceause #10612 enabled unittesting on windows |
|
Thanks! |
This will probably take a couple of hops again. Let's hope for the best...