Run CircleCi with BUILD=debug

[wilzbach]

From @jacob-carlborg on Slack:

I’ve noticed that when compiling DMD in debug mode and running the test the following assertion fails: https://github.com/dlang/dmd/blob/master/src/dmd/dmangle.d#L587
the assertion fails due to one of characters in the mangled name contains a -. Is it the assertion that needs to be updated or is the mangling wrong?
since we’re not testing the compiler in debug mode, as far as I understand, and everything seems to be working I’m guessing the assertion needs to be updated
feels slightly pointless to me with the debug code if it’s never run

This just opens the PR with BUILD=debug. We still need to fix the error in debug mode, but this can be done independently.

[dlang-bot]

Thanks for your pull request, @wilzbach!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#7528"

[wilzbach]

"Good news - the testsuite is really failing:

 ... runnable/test2.sh
core.exception.AssertError@dmd/dmangle.d(587): Assertion failure
----------------
src/core/exception.d:437 onAssertError [0x857548]
src/core/exception.d:633 _d_assertp [0x8462f2]
dmd/dmangle.d:587 _ZN7Mangler5visitEP11Declaration [0x56e5a0]
dmd/dmangle.d:685 _ZN7Mangler11mangleExactEP15FuncDeclaration [0x56e935]
dmd/dmangle.d:1101 _Z11mangleExactP15FuncDeclaration [0x5702e2]
dmd/tocsym.d:304 _ZN8toSymbol8ToSymbol5visitEP15FuncDeclaration [0x6d791e]
dmd/parsetimevisitor.d:53 _ZN16ParseTimeVisitorI10ASTCodegenE5visitEP19UnitTestDeclaration [0x6a9603]
dmd/func.d:3508 _ZN19UnitTestDeclaration6acceptEP7Visitor [0x60c4d7]
dmd/tocsym.d:444 _Z8toSymbolP7Dsymbol [0x6d6f8f]
dmd/glue.d:818 _Z25FuncDeclaration_toObjFileP15FuncDeclarationb [0x6cf1cd]
dmd/toobj.d:311 _ZN9toObjFile9ToObjFile5visitEP15FuncDeclaration [0x6e233a]
dmd/parsetimevisitor.d:53 _ZN16ParseTimeVisitorI10ASTCodegenE5visitEP19UnitTestDeclaration [0x6a9603]
dmd/func.d:3508 _ZN19UnitTestDeclaration6acceptEP7Visitor [0x60c4d7]
dmd/toobj.d:1369 _Z9toObjFileP7Dsymbolb [0x6e2277]
dmd/glue.d:411 _Z10genObjFileP6Moduleb [0x6ce50e]
dmd/mars.d:1019 int dmd.mars.tryMain(ulong, const(char)**) [0x646bf4]
dmd/mars.d:1124 _Dmain [0x64768a]
executing with args: 
DMD v2.078.0-beta.1-76-g822e4fa-dirty DEBUG
Makefile:193: recipe for target 'test_results/runnable/test2.sh.out' failed

For those not using #dmd on Slack, this is due to #6727

[wilzbach]

(rebased)

[MoonlightSentinel]

Can we move forward with this to avoid situations like #10656?

[thewilsonator]

cp: cannot stat 'generated/linux/debug/64/dmd.conf': No such file or directory

Maybe the .conf generation also needs to be redirected also?

[MoonlightSentinel]

It should work as is but build.d skipped dmd.conf for unknown reasons...

[Geod24]

Can we get those PRs rebased instead of creating merge commits please ?

[MoonlightSentinel]

Agreed but I used the web interface because GitHub previously rejected my rebase complaining about runnable_cxx.yml (creating such files in other repos is probably rejected for security reasons).

EDIT; Rebase worked after merging.