Skip to content

Conversation

@wilzbach
Copy link
Contributor

Follow-up to #7420

In #7420 we added the -fPIC run as a new image
as CodeCov was heavily complaining, this simply tests whether this is still the case.

In other words: this PR removes the no-pie x86_64 CircleCi image as in theory x86_32 + x86_64 in pie should cover almost everything that is covered by the three of them.

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @wilzbach!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@WalterBright WalterBright merged commit 35e1dcf into dlang:master Jan 31, 2018
@wilzbach
Copy link
Contributor Author

wilzbach commented Jan 31, 2018

Thanks a lot for merging this @WalterBright - unfortunately I hit the bed before seeing the result here:

image

https://codecov.io/gh/dlang/dmd/compare/7fa030612d7dcb84645cc389714b0268363327eb...2a2444f2d3f2e73e7bf2ed25187566d43e2442e8

image

So it doesn't look good.

(We recently #7711 disabled the display of the overall project coverage change as it (1) the backend has too much global state (i.e. random coverage state) too be informative and (2) it's not relevant to reviewers typically when they look at the diff. The important bit is that the diff is covered and the overall coverage changes are only in a few exceptions (like this one) interesting to look at, but then can be easily accessed by simply clicking on the CodeCov "Details" link in the CI status overview.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants