Revert "Experiment with using only two CircleCi images"#7819
Merged
Revert "Experiment with using only two CircleCi images"#7819
Conversation
Contributor
|
Thanks for your pull request, @wilzbach! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
JinShil
approved these changes
Jan 31, 2018
jacob-carlborg
approved these changes
Jan 31, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #7818 - unfortunately I hit the bed before seeing the result here:
https://codecov.io/gh/dlang/dmd/compare/7fa030612d7dcb84645cc389714b0268363327eb...2a2444f2d3f2e73e7bf2ed25187566d43e2442e8
So it doesn't look good. I should have marked this more as experimental and WIP. Sorry.
(We recently #7711 disabled the display of the overall project coverage change as it (1) the backend has too much global state (i.e. random coverage state) too be informative and (2) it's not relevant to reviewers typically when they look at the diff. The important bit is that the diff is covered and the overall coverage changes are only in a few exceptions (like this one) interesting to look at, but then can be easily accessed by simply clicking on the CodeCov "Details" link in the CI status overview.)