fix Issue 18597 - more unsafe unaligned pointer errors#8019
Merged
dlang-bot merged 1 commit intodlang:masterfrom Mar 23, 2018
Merged
fix Issue 18597 - more unsafe unaligned pointer errors#8019dlang-bot merged 1 commit intodlang:masterfrom
dlang-bot merged 1 commit intodlang:masterfrom
Conversation
Contributor
|
Thanks for your pull request, @WalterBright! Bugzilla references
|
| Type origType = t; | ||
| Type tb = t.toBasetype(); | ||
|
|
||
| const hasPointers = tb.hasPointers(); |
There was a problem hiding this comment.
seems to me like this block would be big enough to put it into a function.
This would help preventing diverging error messages.
Member
Author
|
The autotester on Darwin_64_32 is seg faulting when compiling dmd. Is it using the same version of dmd as the other test platforms? |
Contributor
|
Maybe related: #8022 (comment) |
Member
Author
|
ping @wilzbach |
WalterBright
added
the
Review:Vision
JinShil
approved these changes
Mar 23, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.