-
-
Notifications
You must be signed in to change notification settings - Fork 672
Use supportedFeatures object for feature detection #8022
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for your pull request, @wilzbach! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
Did that PR end up in 2.079.0, because the PR contains a changelog entry. |
|
Yes |
Oh great the random OSX 32-bit segfaults strike again :/ |
|
Is there a core dump available? |
Nope and no ssh either. Despite the coredump wouldn't help much as it's known that 2.068.2 has bugs. |
Those wouldn’t be fixable in a 2.068.3 release? |
|
I was going to create a PR for 2.068 but the plan was to update the autotester version... |
|
Yes that has been agreed upon here: https://forum.dlang.org/post/zbxaviowooiaenaawmgs@forum.dlang.org AFAICT the agreement was the latest DMD compiler + LDC + gdc. The latter two are enforced by SemaphoreCI, so we could update auto-tester ... or well @braddr could. |
|
I see no agreement in that thread. I see no statement of direction. I see a lot of differing opinions and contradictory statements of what can and should be done. No one from dlang leadership has stepped up and said that and what changes need to be made. |
@WalterBright @andralex Does "dlang leadership" mean you? If so, can we get a decision about upgrading the autotester? |
|
This is about the build infra, @MartinNowak would be the decider. |
From Martin's post in the post I linked:
(the travis tests have now been moved to Semaphore) So while gdc is still at 2.068, I don't see anything blocking you from upgrading the auto-tester to newer versions. SemaphoreCI will ensure that DMD is still bootstrap-able with the latest release of the other compilers are still compilable (and who knows maybe there's a GDC release soon - CC @ibuclaw, but from how I understand it that's independent from upograding the auto-tester hosts.) |
|
Hmmm, looks like this commit is the most likely culprit of the OSx failures... |
So essentially you can use whatever version you want, gdc will continue to ensure that there's a feature freeze on the compiler implementation. |
The new JSON output for
-Xi=compilerInfowas added in #7838 and is still not documented and thus we can use the opportunity to make breaking changes.Imho, it's a better idea to group all features in one object as there might be more coming up in the future.
CC @marler8997 @timotheecour