DScanner: Add a minimal .dscanner.ini + start to fix easy DScanner issues#8548
DScanner: Add a minimal .dscanner.ini + start to fix easy DScanner issues#8548dlang-bot merged 2 commits intodlang:masterfrom
Conversation
|
Thanks for your pull request, @wilzbach! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + dmd#8548" |
| ; - GOTO: Remove a module | ||
| ; | ||
| ; Some checks are currently disabled. | ||
| [analysis.config.ModuleFilters] |
There was a problem hiding this comment.
This is just a very simplistic blacklist. For Phobos, we generated the entire blacklist for important checks.
See: dlang/phobos#5501
| return returnEarly(); | ||
| } | ||
| } | ||
| else if (!needExpansion) |
There was a problem hiding this comment.
The changes between here and line 946 seem unrelated to the PR.
There was a problem hiding this comment.
dmd/statementsem.d(918:18)[warn]: Mismatched static if. Use 'else static if' here.
src/posix.mak
Outdated
| # runs static code analysis with Dscanner | ||
| dscanner: $(DSCANNER_DIR)/dsc | ||
| @echo "Running DScanner" | ||
| $(DSCANNER_DIR)/dsc --config .dscanner.ini --styleCheck $$(find dmd -name "*.d" | grep -v "func.d") -I. |
There was a problem hiding this comment.
Exclusion of func.d was necessary as libdparse currently isn't able to parse.
See dlang-community/libdparse#258
There was a problem hiding this comment.
This can be removed already. Just update the submodule in D-Scanner and the hash in this PR.
There was a problem hiding this comment.
new hash : 3a859d39c4b59822b1bc0452b3ddcd598ef390a2
7293912 to
bfb3a6d
Compare
- redundant attributes - redundant if/else - empty declarations - misleading static if, else

constonopEqualsortoHashCC @bbasile