Skip to content

convert cod4.c to D#8616

Merged
dlang-bot merged 1 commit intodlang:masterfrom
WalterBright:cod4.d
Aug 29, 2018
Merged

convert cod4.c to D#8616
dlang-bot merged 1 commit intodlang:masterfrom
WalterBright:cod4.d

Conversation

@WalterBright
Copy link
Member

No description provided.

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @WalterBright!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + dmd#8616"

@WalterBright WalterBright force-pushed the cod4.d branch 6 times, most recently from 536db7f to 1ea6f05 Compare August 29, 2018 01:24
@WalterBright
Copy link
Member Author

Does anyone who has an account with buildkite know what the problem is?

@JinShil
Copy link
Contributor

JinShil commented Aug 29, 2018

Running DScanner
../generated/linux/release/64/dscanner-3a859d39c4b59822b1bc0452b3ddcd598ef390a2/dsc --config .dscanner.ini --styleCheck dmd -I.
dmd/backend/cod4.d(2485:5)[warn]: Empty declaration
posix.mak:606: recipe for target 'dscanner' failed
Running DScanner
../generated/linux/release/64/dscanner-3a859d39c4b59822b1bc0452b3ddcd598ef390a2/dsc --config .dscanner.ini --styleCheck dmd -I.
dmd/backend/cod4.d(2485:5)[warn]: Empty declaration
posix.mak:606: recipe for target 'dscanner' failed
Running DScanner
../generated/linux/release/64/dscanner-3a859d39c4b59822b1bc0452b3ddcd598ef390a2/dsc --config .dscanner.ini --styleCheck dmd -I.
dmd/backend/cod4.d(2485:5)[warn]: Empty declaration
posix.mak:606: recipe for target 'dscanner' failed

See also #8548 for context, and 06633f4 for potential solution.

@WalterBright
Copy link
Member Author

@JinShil thanks, that did the trick!

@dlang-bot dlang-bot merged commit 4971422 into dlang:master Aug 29, 2018
@jacob-carlborg
Copy link
Contributor

@wilzbach doesn't Walter have a buildkite account?

@WalterBright WalterBright deleted the cod4.d branch August 29, 2018 08:22
@WalterBright
Copy link
Member Author

I suppose I could sign up, but I tire of the endless accounts I have (several hundred). I'd like it if buildkite could simply produce a log anyone could read, like the other testers. I confess I don't even know what buildkite is or why we need it.

@jacob-carlborg
Copy link
Contributor

@WalterBright I think you can login with your GitHub account. Buildkite is intended to replace Jenkins.

@jacob-carlborg
Copy link
Contributor

The idea is that it should be public, but Buildkite needs to do that (approve it is an open source project, or something like that). We have asked for that but nothing has happened yet, as far as I know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments