Remove string mixin from _d_arrayappendcTX#3870
Conversation
|
Thanks for your pull request and interest in making D better, @dkorpel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + druntime#3870" |
src/core/internal/array/appending.d
Outdated
There was a problem hiding this comment.
while we're changing this, please move this pragma outside of the function
thewilsonator
left a comment
There was a problem hiding this comment.
otherwise looks good
|
cc @teodutu . Does this affect your current work in any way? |
|
@RazvanN7, no. |
|
Maybe a rebase will fix the vibe.d failure? |
|
Vibe failure is unrelated, so merging this as is. |
|
It looks related to me: I think the |
|
Hmm, I couldn't see that error message. Maybe it's required that the function body is a string so that ctfe can interpret it? |
It was introduced in #2632, but the two branches look identical to me.