Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.
/ druntime Public archive

Revert "Remove string mixin from _d_arrayappendcTX"#3874

Closed
RazvanN7 wants to merge 1 commit intomasterfrom
revert-3870-remove-mixin
Closed

Revert "Remove string mixin from _d_arrayappendcTX"#3874
RazvanN7 wants to merge 1 commit intomasterfrom
revert-3870-remove-mixin

Conversation

@RazvanN7
Copy link
Contributor

@RazvanN7 RazvanN7 commented Jul 8, 2022

Reverts #3870 so that we don't block the testing pipelines.

cc @dkorpel

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @RazvanN7! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + druntime#3874"

@dkorpel
Copy link
Contributor

dkorpel commented Jul 8, 2022

I think #3873 will fix it

@RazvanN7 RazvanN7 closed this Jul 8, 2022
@dkorpel dkorpel deleted the revert-3870-remove-mixin branch July 8, 2022 12:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments