Add std.string.outdent (try #3) #282
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
There was a problem hiding this comment.
You could just do foreach(ref line; lines) and skip the index.
Contributor
Author
There was a problem hiding this comment.
Indeed. I think the indicies are holdovers from old versions.
Contributor
Author
There was a problem hiding this comment.
I remember why I did that: If I just use foreach(ref line; lines), then it breaks under CTFE.
Member
There was a problem hiding this comment.
Ah. Okay. Hopefully that restriction gets fixed at some point.
Member
|
Well, unless Andrei has anything more to add, this looks like it's good to go. |
andralex
added a commit
that referenced
this pull request
Oct 3, 2011
Add std.string.outdent (try #3)
Member
|
Thanks for your work. |
marler8997
pushed a commit
to marler8997/phobos
that referenced
this pull request
Nov 10, 2019
Bump libdparse
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This puts everything from pull request #228 into one commit.