Skip to content

Conversation

@kyllingstad
Copy link
Contributor

Minor bug/doc fixes

This reverts commit d92bee0.
Probably the makefile is not the right place to do this, rather
librt should be included in dmd.conf.
My earlier fix for issue 5052, "take!(Take!R) should return Take!R, not
Take!(Take!R)", broke David's fix for issue 4464, "std.range.take does
not always return Take!R".  This commit should fix both issues.

The special case when typeof(R.opSlice()) !=  R is now also accounted
for.
@braddr
Copy link
Member

braddr commented Feb 7, 2011

I think this pull request is a good example of where some git rebasing would be useful. The revision history is a little messy including a change and a revert. The master branch history doesn't need to include those extra steps. It's not particularly harmful, but it's also easy to fix.

@kyllingstad
Copy link
Contributor Author

Thanks for the tip! I've never really used 'git rebase', so it didn't occur to me. I guess it's too late to do anything about it now, but I'll keep it in mind for later.

Fortunately, the diff for this request is much cleaner than would appear from the commit list. ;)

@jmdavis
Copy link
Member

jmdavis commented Feb 9, 2011

Well, while the list of commits isn't as clean as would be nice (I suspect that all of us are going to stumble a bit at first at figuring out when to rebase and whatnot), the diff certainly looks good. Does anyone have any reason not to merge it in at this point?

@jmdavis
Copy link
Member

jmdavis commented Feb 9, 2011

Okay. It's been merged in now.

andralex added a commit that referenced this pull request Oct 3, 2011
Add std.string.outdent (try #3)
jkrempus pushed a commit to jkrempus/phobos that referenced this pull request Dec 25, 2012
Merge Jerro's improvements to Normal Ziggurat engine and tweaks elsewhere.
DmitryOlshansky added a commit to DmitryOlshansky/phobos that referenced this pull request Aug 12, 2013
DmitryOlshansky added a commit to DmitryOlshansky/phobos that referenced this pull request Aug 17, 2013
DmitryOlshansky referenced this pull request in DmitryOlshansky/phobos Apr 7, 2014
It's a step zero to get decode-less std.regex.
UTF matchers are efficient functors around a set of
specific tries. Enables processing Unicode characters
without decoding at speeds on par with decoding itself.

Fix a shameful typo in setSearcher.
Kozzi11 pushed a commit to Kozzi11/phobos that referenced this pull request Dec 29, 2014
std.math: use most inline x86/x64 assembly only if real is defined as x87
ntrel pushed a commit to ntrel/phobos that referenced this pull request Apr 7, 2016
Make staticArray(T[n]) unittest @nogc, tweak docs
wilzbach added a commit that referenced this pull request Jul 21, 2017
Add documentation and unittests regarding multisets - take #3
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants