-
-
Notifications
You must be signed in to change notification settings - Fork 746
Issues 2874, 4464 and 4807 #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit d92bee0. Probably the makefile is not the right place to do this, rather librt should be included in dmd.conf.
My earlier fix for issue 5052, "take!(Take!R) should return Take!R, not Take!(Take!R)", broke David's fix for issue 4464, "std.range.take does not always return Take!R". This commit should fix both issues. The special case when typeof(R.opSlice()) != R is now also accounted for.
|
I think this pull request is a good example of where some git rebasing would be useful. The revision history is a little messy including a change and a revert. The master branch history doesn't need to include those extra steps. It's not particularly harmful, but it's also easy to fix. |
|
Thanks for the tip! I've never really used 'git rebase', so it didn't occur to me. I guess it's too late to do anything about it now, but I'll keep it in mind for later. Fortunately, the diff for this request is much cleaner than would appear from the commit list. ;) |
|
Well, while the list of commits isn't as clean as would be nice (I suspect that all of us are going to stumble a bit at first at figuring out when to rebase and whatnot), the diff certainly looks good. Does anyone have any reason not to merge it in at this point? |
|
Okay. It's been merged in now. |
Add std.string.outdent (try #3)
Merge Jerro's improvements to Normal Ziggurat engine and tweaks elsewhere.
It's a step zero to get decode-less std.regex. UTF matchers are efficient functors around a set of specific tries. Enables processing Unicode characters without decoding at speeds on par with decoding itself. Fix a shameful typo in setSearcher.
std.math: use most inline x86/x64 assembly only if real is defined as x87
Make staticArray(T[n]) unittest @nogc, tweak docs
Add documentation and unittests regarding multisets - take #3
Minor bug/doc fixes