std.socket: Decorate Socket methods

[CyberShadow]

In particular, send/receive weren't @nogc.

[JackStouffer]

LGTM other than the 32 bit issues.

[wilzbach]

Does const on a void method make sense?

[CyberShadow]

Yes? It means that the object itself will not be modified.

A different question would be, does const on a method that mutates the state of what it is representing (OS socket) make sense?

[DmitryOlshansky]

const applies to this pointer so obviously yes

[CyberShadow]

Gahhh. So send can't be @nogc because it does a "safe" conversion of size_t to int on Windows?

I think this is a case where it should be turned into a cast. No one is going to send 2GB of data via a socket in one go on Windows, right?

[DmitryOlshansky]

I think this is a case where it should be turned into a cast. No one is going to send 2GB of data via a socket in one go on Windows, right?

Me thinks yes

[CyberShadow]

Oh, as it turns out that's not even necessary because send doesn't guarantee that it sends everything, and returns the number of bytes sent.

[DmitryOlshansky]

Auto-merge toggled on

[JackStouffer]

@safe pure?

[CyberShadow]

@safe is implicit (declared at the top of the module). pure makes no difference here because it is a private method called only by non-pure methods.

[CyberShadow]

This pull request introduced a regression:
https://issues.dlang.org/show_bug.cgi?id=16514