Skip to content

Conversation

@CyberShadow
Copy link
Member

@dlang-bot
Copy link
Contributor

Fix Bugzilla Description
16514 std.socket methods are const, and thus cannot be overriden for SSLSocket, for example

@CyberShadow CyberShadow added this to the 2.072.0 milestone Oct 14, 2016
@CyberShadow
Copy link
Member Author

@wilzbach Do I need to do something about the codecov "failure"?

@wilzbach
Copy link
Contributor

wilzbach commented Oct 20, 2016

@wilzbach Do I need to do something about the codecov "failure"?

Not at all - it's just warning you that by reverting you remove some tests and thus the overall coverage. That's why it's only a warning and not required ;-)

edit: the added tests isn't executed, thus the "new unhit" lines.

@CyberShadow
Copy link
Member Author

Thanks. Though I think the decreased coverage is due to the compilation "test", which generates uncovered (and uncoverable) lines.

@MartinNowak MartinNowak merged commit 0c41f51 into dlang:stable Oct 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants