Enables long line style check.#4974
Merged
dlang-bot merged 1 commit intodlang:masterfrom Dec 21, 2016
skl131313:long-lines-check
Merged
Enables long line style check.#4974dlang-bot merged 1 commit intodlang:masterfrom skl131313:long-lines-check
dlang-bot merged 1 commit intodlang:masterfrom
skl131313:long-lines-check
Conversation
wilzbach
reviewed
Dec 20, 2016
| */ | ||
| deprecated("It will be removed from Phobos in October 2016. If you still need it, go to https://github.com/DigitalMars/undeaD") | ||
| deprecated("It will be removed from Phobos in October 2016. "~ | ||
| "If you still need it, go to https://github.com/DigitalMars/undeaD") |
Contributor
There was a problem hiding this comment.
It will be removed from Phobos in October 2016.
Seems like there is more work to do :)
CC @jmdavis
wilzbach
approved these changes
Dec 20, 2016
Contributor
wilzbach
left a comment
wilzbach
left a comment
There was a problem hiding this comment.
Thanks for going ahead with this one!
As this has been approved before, I will directly go ahead with this one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There doesn't seem to be a style guide for long lines, so I grouped the logic where possible. Perhaps additional rules could be added to the style guide on what to do for long lines.