Skip to content

Remove deprecated doFormat#4978

Merged
JackStouffer merged 1 commit intodlang:masterfrom
wilzbach:remove-doformat
Dec 24, 2016
Merged

Remove deprecated doFormat#4978
JackStouffer merged 1 commit intodlang:masterfrom
wilzbach:remove-doformat

Conversation

@wilzbach
Copy link
Contributor

Apparently we missed the deprecation cleanup on this one.

It's part of undeaD:

https://github.com/dlang/undeaD/blob/master/src/undead/doformat.d

Copy link
Member

@quickfur quickfur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skl131313
Copy link
Contributor

Looks like a test in DMD still uses doFormat:

https://github.com/dlang/dmd/blob/master/test/runnable/imports/argufile.d#L21

@wilzbach
Copy link
Contributor Author

Looks like a test in DMD still uses doFormat:

-> dlang/dmd#6346

@wilzbach wilzbach added this to the 2.073.0-b0 milestone Dec 21, 2016
@wilzbach
Copy link
Contributor Author

-> dlang/dmd#6346

This is in now - so we can go ahead :)

@wilzbach wilzbach added the Review:Trivial typos, formatting, comments label Dec 22, 2016
@JackStouffer
Copy link
Contributor

What's up with the CI failure?

@wilzbach
Copy link
Contributor Author

What's up with the CI failure?

This has to do with the new public unittest tester: to avoid random failures a specific git version of the tools repo is checked out.
The problem is that we do a git clone with --depth 1 by default and just recently a new commit got into the tools repo, s.t. the checked out version isn't fetched anymore due.

-> #4955

@wilzbach
Copy link
Contributor Author

What's up with the CI failure?

The CircleCi fix is in & now it's green again :)

@JackStouffer
Copy link
Contributor

Auto-merge toggled on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Review:Trivial typos, formatting, comments

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants